Skip to content

Commit

Permalink
Add skips for unreliable or racy tests
Browse files Browse the repository at this point in the history
  • Loading branch information
eregon committed Mar 23, 2020
1 parent c68ae2c commit ff89f1f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/test_integration_pumactl.rb
Expand Up @@ -20,7 +20,7 @@ def teardown
end

def test_stop_tcp
skip_on :jruby # Undiagnose thread race. TODO fix
skip_on :jruby, :truffleruby # Undiagnose thread race. TODO fix
@control_tcp_port = UniquePort.call
cli_server "-q test/rackup/sleep.ru --control-url tcp://#{HOST}:#{@control_tcp_port} --control-token #{TOKEN} -S #{@state_path}"

Expand Down
3 changes: 2 additions & 1 deletion test/test_thread_pool.rb
Expand Up @@ -64,7 +64,7 @@ def test_append_queues_on_max
end

def test_trim
skip_on :jruby # Undiagnose thread race. TODO fix
skip_on :jruby, :truffleruby # Undiagnose thread race. TODO fix
pool = new_pool(0, 1) do |work|
@work_mutex.synchronize do
@work_done.signal
Expand All @@ -87,6 +87,7 @@ def test_trim
end

def test_trim_leaves_min
skip_on :truffleruby # Undiagnose thread race. TODO fix
pool = new_pool(1, 2) do |work|
@work_mutex.synchronize do
@work_done.signal
Expand Down

0 comments on commit ff89f1f

Please sign in to comment.