Minor logic DRY up

puma · Dec 26, 2022 · dead2b4 · dead2b4
1 parent dc2b6ee
commit dead2b4
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/lib/puma/client.rb b/lib/puma/client.rb
@@ -214,8 +214,8 @@ def try_to_parse_proxy_protocol
     end
 
     def try_to_finish
-      if env[CONTENT_LENGTH] && @http_content_length_limit
-        @http_content_length_limit_exceeded = env[CONTENT_LENGTH].to_i > @http_content_length_limit
+      if env[CONTENT_LENGTH] && above_http_content_limit(env[CONTENT_LENGTH].to_i)
+        @http_content_length_limit_exceeded = true
       end
 
       if @http_content_length_limit_exceeded
@@ -254,7 +254,7 @@ def try_to_finish
 
       @parsed_bytes = @parser.execute(@env, @buffer, @parsed_bytes)
 
-      if @parser.finished? && @http_content_length_limit && (@parser.body.bytesize > @http_content_length_limit)
+      if @parser.finished? && above_http_content_limit(@parser.body.bytesize)
         @http_content_length_limit_exceeded = true
       end
 
@@ -613,5 +613,9 @@ def set_ready
       @requests_served += 1
       @ready = true
     end
+
+    def above_http_content_limit(value)
+      @http_content_length_limit&.< value
+    end
   end
 end