Strip header whitespace. Fix #1890. Code by @matthewd

puma · Oct 4, 2019 · b38fbd3 · b38fbd3
1 parent 0bbb495
commit b38fbd3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ext/puma_http11/puma_http11.c b/ext/puma_http11/puma_http11.c
@@ -200,6 +200,8 @@ void http_field(puma_parser* hp, const char *field, size_t flen,
     f = rb_str_new(hp->buf, new_size);
   }
 
+	while (vlen > 0 && isspace(value[vlen - 1])) vlen--;
+
   /* check for duplicate header */
   v = rb_hash_aref(hp->request, f);
 

diff --git a/test/test_http11.rb b/test/test_http11.rb
@@ -199,9 +199,7 @@ def test_horrible_queries
     end
   end
 
-  # https://github.com/puma/puma/issues/1890
   def test_trims_whitespace_from_headers
-    skip("Known failure, see issue 1890 on GitHub")
     parser = Puma::HttpParser.new
     req = {}
     http = "GET / HTTP/1.1\r\nX-Strip-Me: Strip This       \r\n\r\n"