-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move threadpool init out of server (#2942)
* Simplify `ThreadPool` initializations code in `Puma::Server` This commit introduces four `ThreadPool` options in `Configuration::DEFAULTS`: `auto_trim_time`, `reaping_time`, `clean_thread_locals`, and `out_of_band_hook` they could be configured via file/user options `Puma::Configuration`. The auto reap/trim methods stay in `Puma::Server` because the way we test in `Puma::Server` tests. Adds `slice(keys)` method to `UserFileDefaultOptions` so it acts like a Hash and we could read `ThreadPool` options from the user-file-default options. Adds missing require statement to `test/test_puma_server.rb`, so this test could run individually. Co-Authored-By: Shohei Umemoto <cafedomancer@gmail.com> Co-Authored-By: Nate Berkopec <nate.berkopec@gmail.com> * Fix out of band * Fixup lib files * Fixup tests Co-authored-by: Juanito Fatas <me@juanitofatas.com> Co-authored-by: Shohei Umemoto <cafedomancer@gmail.com> Co-authored-by: MSP-Greg <Greg.mpls@gmail.com>
- Loading branch information
1 parent
5199ff2
commit 317e890
Showing
7 changed files
with
39 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters