Close file stream when reading pid from pidfile (#2048)

* close file stream when reading pid from pidfile * add changelog
puma · Oct 21, 2019 · 14782fd · 14782fd
1 parent c379424
commit 14782fd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/History.md b/History.md
@@ -8,6 +8,7 @@
 * Bugfixes
   * Fix Errno::EINVAL when SSL is enabled and browser rejects cert (#1564)
   * Fix pumactl defaulting puma to development if an environment was not specified (#2035)
+  * Fix closing file stream when reading pid from pidfile (#2048)
 
 ## 4.2.1 / 2019-10-07
 

diff --git a/lib/puma/control_cli.rb b/lib/puma/control_cli.rb
@@ -132,7 +132,7 @@ def prepare_configuration
         @pid = sf.pid
       elsif @pidfile
         # get pid from pid_file
-        @pid = File.open(@pidfile).gets.to_i
+        File.open(@pidfile) { |f| @pid = f.read.to_i }
       end
     end