New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Preliminary support for GitHub merge queues #37
Conversation
RE: lint failure: actionlint probably needs to be updated https://github.com/pulumi/watchutil-rs/blob/main/.github/workflows/ci-lint.yml#L25C18-L25C45 |
Changelogn/a |
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
bors merge |
37: ci: Preliminary support for GitHub merge queues r=blampe a=blampe It occurred to me that `@AaronFriel` had setup this repo to test Bors. It would make sense to also use it as a guinea pig for merge queues before landing pulumi/pulumi#13681. Co-authored-by: Bryce Lampe <bryce@pulumi.com>
Build failed: |
bors retry |
37: ci: Preliminary support for GitHub merge queues r=blampe a=blampe It occurred to me that `@AaronFriel` had setup this repo to test Bors. It would make sense to also use it as a guinea pig for merge queues before landing pulumi/pulumi#13681. Co-authored-by: Bryce Lampe <bryce@pulumi.com>
Build failed: |
bors retry |
37: ci: Preliminary support for GitHub merge queues r=blampe a=blampe It occurred to me that `@AaronFriel` had setup this repo to test Bors. It would make sense to also use it as a guinea pig for merge queues before landing pulumi/pulumi#13681. Co-authored-by: Bryce Lampe <bryce@pulumi.com>
Build failed: |
bors merge |
37: ci: Preliminary support for GitHub merge queues r=blampe a=blampe It occurred to me that `@AaronFriel` had setup this repo to test Bors. It would make sense to also use it as a guinea pig for merge queues before landing pulumi/pulumi#13681. Co-authored-by: Bryce Lampe <bryce@pulumi.com>
Build failed: |
@@ -30,11 +31,11 @@ jobs: | |||
|
|||
./.github/scripts/set-output version "${VERSION}" | |||
- name: Install git-cliff | |||
uses: baptiste0928/cargo-install@bf6758885262d0e6f61089a9d8c8790d3ac3368f # v1.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why this is unpinned? Best practice is to pin to a commit SHA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AaronFriel I'm just trying to get the build passing, seems it's been red for a while. I'll change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AaronFriel the remaining failure is on the release step, and I'm pretty out of my element. It seems like pu/pu migrated to cosign in pulumi/pulumi#11310, so my plan was to try porting that over to this repo. Would love to hear if you have alternatives before I go down that path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed 1:1, I've disabled the signing step.
bors merge |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
It occurred to me that @AaronFriel had setup this repo to test Bors. It would make sense to also use it as a guinea pig for merge queues before landing pulumi/pulumi#13681.