Provider support for dotnet #9496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
force-pushed
the
fraser/dotnetProvider
branch
from
4928c80
to
db01deb
Compare
Changelog[uncommitted] (2022-11-28) |
Frassle
force-pushed
the
fraser/dotnetProvider
branch
3 times, most recently
from
1e6d5f2
to
152e3ad
Compare
Frassle
force-pushed
the
fraser/dotnetProvider
branch
4 times, most recently
from
26e761a
to
d0a7814
Compare
This adds a new namespace to the dotnet sdk "Provider" with classes to support the writing of a native dotnet provider. The Provider class will internally deal with our grpc protocol and call into virtual methods given by the user which use only dotnet native domain models. It is a bit sad all this is manually written, I feel like there _might_ be a good way to codegen this from the protobuf specs such that if they ever change this file could stay in sync. Also the PropertyValue Marshal/Unmarshal duplicates a lot of the existing serialisation logic, and I think that logic could be rewritten as a layer ontop of this (that is we'd have "objects -> PropertyValues" and "PropetyValues -> grpc" rather than what we currently have which is "objects -> grpc" and now "PropertyValues -> grpc")
Zaid-Ajaj
reviewed
Nov 27, 2022
| public sealed class InvokeResponse | ||
| { | ||
|
|
||
| public IDictionary<string, PropertyValue>? Return { get; set; } |
There was a problem hiding this comment.
With the work being done in #11418, it should be possible to define an invoke response that returns a single PropertyValue rather than a bag of these
There was a problem hiding this comment.
Yeh I'll probably rejig this, few other things I've copied from the go SDK which are more legacy than really needed.
Frassle
force-pushed
the
fraser/dotnetProvider
branch
from
d0a7814
to
744f802
Compare
|
I'll move this over to pulumi-dotnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new namespace to the dotnet sdk "Provider" with classes to support the writing of a native dotnet provider.
The Provider class will internally deal with our grpc protocol and call into virtual methods given by the user which use only dotnet native domain models.
It is a bit sad all this is manually written, I feel like there might be a good way to codegen this from the protobuf specs such that if they ever change this file could stay in sync.
Also the PropertyValue Marshal/Unmarshal duplicates a lot of the existing serialization logic, and I think that logic could be rewritten as a layer ontop of this (that is we'd have "objects -> PropertyValues" and "PropetyValues -> grpc" rather than what we currently have which is "objects -> grpc" and now "PropertyValues -> grpc")
Checklist