New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support full fidelity YAML round-tripping #6489
Conversation
5112c7d
to
d893394
Compare
9b27bc7
to
f42d0f0
Compare
b19369e
to
b16fc49
Compare
This change uses the new YAML parsing library to to implement full fidelity round-tripping of config files. Any comments and formatting will now be preserved when Pulumi writes changes to disk.
59070f6
to
5faf2a5
Compare
Rebasing this looks tractable -- is it worth bringing it up to date, @lblackstone? I can review it. |
Check out this comment about the state I left this in. The following comments in that thread also make me question whether the current duality of using the config as both user-editable as well as Pulumi-editable actually makes sense. I'll defer to @pulumi/platform on the latter question. |
@Frassle I think this looks like a good candidate to pull in to this or the next iteration as we're considering adding another place where we mutate the stack config: seeding names. |
I don't think we're going to get away from that. If anything its going to get worse with ideas around yaml programs wanting to modify the
Yeh if this is close to done and doesn't have any major issues it would be good to get finished. |
Implemented in #11456 |
This change uses the new YAML parsing library to
to implement full fidelity round-tripping of config files.
Any comments and formatting will now be preserved
when Pulumi writes changes to disk.
Fix #423
Fix #6480
Fix #5235
TODO:
Update Project and PolicyPackProject round-tripping(Going to follow up with this later)