Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the build to target Node14 now that it is LTS #5673

Merged
merged 1 commit into from Nov 4, 2020
Merged

Upgrade the build to target Node14 now that it is LTS #5673

merged 1 commit into from Nov 4, 2020

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Nov 3, 2020 •
edited

Fixes: #4595

@stack72 stack72 force-pushed the node14 branch 2 times, most recently from 73eeb79 to b0d1dad Compare November 3, 2020 18:11
@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azuread with merge commit 2569026

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-random with merge commit 2569026

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-kubernetes with merge commit 2569026

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azure with merge commit 2569026

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-aws with merge commit 2569026

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-gcp with merge commit 2569026

@github-actions
Copy link

github-actions bot commented Nov 4, 2020

Diff for pulumi-azuread with merge commit 6560fd8

@github-actions
Copy link

github-actions bot commented Nov 4, 2020

Diff for pulumi-random with merge commit 6560fd8

@github-actions
Copy link

github-actions bot commented Nov 4, 2020

Diff for pulumi-kubernetes with merge commit 6560fd8

@stack72 stack72 self-assigned this Nov 4, 2020
@github-actions
Copy link

github-actions bot commented Nov 4, 2020

Diff for pulumi-azure with merge commit 6560fd8

@github-actions
Copy link

github-actions bot commented Nov 4, 2020

Diff for pulumi-aws with merge commit 6560fd8

@github-actions
Copy link

github-actions bot commented Nov 4, 2020

Diff for pulumi-gcp with merge commit 6560fd8

@stack72 stack72 added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 4, 2020
komalali
komalali approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@komalali komalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on whether or not we actually need strategy.matrix if we're not testing in a number of configurations, but otherwise LGTM!

.github/workflows/master.yml Show resolved Hide resolved
@stack72 stack72 merged commit 518d458 into master Nov 4, 2020
@stack72 stack72 deleted the node14 branch November 4, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komalali komalali komalali approved these changes

@jaxxstorm jaxxstorm Awaiting requested review from jaxxstorm

Assignees

@stack72 stack72

Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 14 compatibility
2 participants
@stack72 @komalali