be consistent in the way we round seconds #16070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases we only display full seconds, particularly when rendering the summary event, and when converting the engine event for use in the API. However we are currently not consistent with that, rounding up in the display code and rounding down when converting the engine event. It probably doesn't matter what exactly we are doing here, but for writing display snapshot tests it does. Let's split the difference here, and always round to the nearest second.
tgummerer
added
the
impact/no-changelog-required
Changelog[uncommitted] (2024-04-29) |
Frassle
approved these changes
Apr 26, 2024
|
Removing from queue. Just hit me why we round up in display, it's stop things saying the took "0s". We probably want to keep that behaviour, so roundup in engine events instead? |
Ah that makes sense. I've adjusted it to always round up now. |
Frassle
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases we only display full seconds, particularly when rendering the summary event, and when converting the engine event for use in the API. However we are currently not consistent with that, rounding up in the display code and rounding down when converting the engine event.
It probably doesn't matter what exactly we are doing here, but for writing display snapshot tests it does. Let's split the difference here, and always round up, so we never give the impression that the operation took no time.
It doesn't look like Pulumi Cloud shows this at all, so it probably doesn't matter for users, and we could just round up for everyone as well. I don't have strong opinions about that.