Start mypy linting lib/test #16040
Merged
Start mypy linting lib/test #16040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
added
the
impact/no-changelog-required
Changelog[uncommitted] (2024-04-30) |
justinvp
reviewed
Apr 23, 2024
Frassle
force-pushed
the
fraser/mypyReturn
branch
from
8cd64fd
to
2cf6fec
Compare
This fixes up a load of '[un]expected return statement' errors in the tests. Mostly property getters which I've filled in with `pulumi.get` but some of the tests were explictly checking things worked when the getter was an empty method body.
Frassle
force-pushed
the
fraser/mypyReturn
branch
from
2cf6fec
to
b6ee1dd
Compare
tgummerer
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes up a load of '[un]expected return statement' errors in the tests. Mostly property getters which I've filled in with
pulumi.getbut some of the tests were explictly checking things worked when the getter was an empty method body.