Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add a status message for unchanged resources #15975

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Apr 18, 2024

These changes add a status message with the count of unchanged resources
to the lower-left corner of the display. This is useful as a measure of
progress for updates that are mostly free of changes.

These changes add a status message with the count of unchanged resources
to the lower-left corner of the display. This is useful as a measure of
progress for updates that are mostly free of changes.
@pgavlin pgavlin requested a review from a team as a code owner April 18, 2024 05:28
@pgavlin
Copy link
Member Author

pgavlin commented Apr 18, 2024

Will grab an example screenshot or recording.

@pgavlin pgavlin closed this Apr 18, 2024
@pgavlin pgavlin reopened this Apr 18, 2024
@pgavlin pgavlin added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Apr 18, 2024
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2024-04-18)

@pgavlin pgavlin requested a review from justinvp April 18, 2024 18:04
@justinvp
Copy link
Member

Nice. Looks reasonable to me. Bottom left seems like a reasonable place for it (though, I'm also curious if anyone has other ideas where it should be placed). I'd love to take this for a quick spin before merging it, but haven't had a chance to try it yet. Will try it out tomorrow.

@justinvp
Copy link
Member

justinvp commented Apr 19, 2024

I tried this out with this example: pulumi new static-website-aws-go.

After the initial pulumi up, I run pulumi up again and get this:

Screenshot 2024-04-19 at 4 30 30 PM

Note the discrepancy between the "10 unchanged" for this new feature, and the existing "Resources" summary which says "8 unchanged".

Also, should we hide this at the end, since the summary already mentions how many unchanged resources there are? Or if not hiding it, adding some line spaces between the tree and the "Resources:"?

When I do run the update, then the numbers agree. But still wondering if it should be hidden):

Screenshot 2024-04-19 at 4 33 06 PM

@pgavlin
Copy link
Member Author

pgavlin commented Apr 20, 2024

Note the discrepancy between the "10 unchanged" for this new feature, and the existing "Resources" summary which says "8 unchanged".

Yeah that's odd. Definitely want these to agree.

Also, should we hide this at the end, since the summary already mentions how many unchanged resources there are? Or if not hiding it, adding some line spaces between the tree and the "Resources:"?

Yes, definitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants