Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close files in PCL binder #15961

Merged
merged 2 commits into from May 8, 2024
Merged

fix: close files in PCL binder #15961

merged 2 commits into from May 8, 2024

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Apr 17, 2024 •
edited by Frassle

Description

Close files in PCL parser after parsing.

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@testwill testwill requested a review from a team as a code owner April 17, 2024 05:36
@github-actions GitHub Actions
Copy link

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Apr 17, 2024 •
edited

Changelog

[uncommitted] (2024-05-07)

@testwill
fix: close flles
cbf6b59 
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
@github-actions GitHub Actions
Copy link

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@Frassle Frassle changed the title fix: close flles fix: close files in PCL binder Apr 17, 2024
@Frassle Frassle added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Apr 17, 2024
Frassle
Frassle approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@Frassle Frassle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@Frassle Frassle enabled auto-merge April 17, 2024 13:06
@Frassle Frassle added this pull request to the merge queue Apr 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2024
Frassle
Frassle reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@Frassle Frassle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this needs the import added for the contract module from the sdk folder.

@mikhailshilkov
Copy link
Member

@testwill Will you be able to adjust the PR based on @Frassle feedback above? Or do you need help?

@testwill
Copy link
Contributor Author

testwill commented May 7, 2024

need help

@mikhailshilkov
Copy link
Member

@Frassle Can you help land it?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@justinvp
Copy link
Member

justinvp commented May 7, 2024 •
edited by pulumi-bot

/run-acceptance-tests
Please view the results of the acceptance tests Here

@justinvp justinvp added this pull request to the merge queue May 7, 2024
Merged via the queue into pulumi:master with commit ff8c44f May 8, 2024
9 of 16 checks passed
@justinvp
Copy link
Member

justinvp commented May 8, 2024

Thanks @testwill!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frassle Frassle Frassle approved these changes

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@testwill @pulumi-bot @mikhailshilkov @justinvp @Frassle