Enable deployment settings in source control #15945
Conversation
Changelog[uncommitted] (2024-04-15) |
| deployment apitype.DeploymentSettings, | ||
| ) error { | ||
| // The local backend does not currently persist tags. | ||
| return errors.New("stack deployments not supported in --local mode") |
There was a problem hiding this comment.
| return errors.New("stack deployments not supported in --local mode") | |
| return errors.New("stack deployments not supported with diy backends") |
Similar below, as someone might not be using --local, but azure blob or s3 or similar backends, where --local would be somewhat confusing.
| func (pc *Client) UpdateStackDeployment(ctx context.Context, stack StackIdentifier, | ||
| deployment apitype.DeploymentSettings, | ||
| ) error { | ||
| // TODO(german): validate deployment |
There was a problem hiding this comment.
Is this worth doing now? Otherwise can we write down which validations we expect to do here? I guess the backend will also do its own validation anyway, so we would be getting an error here if the deployment isn't valid?
There was a problem hiding this comment.
We should probably remove the TODO. No need for us to validate CLI side of the service can do it better.
| } | ||
|
|
||
| func (pc *Client) DestroyStackDeployment(ctx context.Context, stack StackIdentifier) error { | ||
| // TODO(german): validate deployment |
There was a problem hiding this comment.
It doesn't look like we have a deployment to validate here? Is this TODO accurate?
| } | ||
|
|
||
| func (pc *Client) GetStackDeployment(ctx context.Context, stack StackIdentifier) (*apitype.DeploymentSettings, error) { | ||
| // TODO(german): validate deployment |
There was a problem hiding this comment.
Is this supposed to be validating the response? Something else?
|
|
||
| func newDeploymentsCmd() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "deployments", |
There was a problem hiding this comment.
| Use: "deployments", | |
| Use: "deployment", |
Should we be using the singular form here, since each invocation will only affect a single deployment afaics?
|
@tgummerer @Frassle sry, this was meant to be a draft PR. Started as a PoC and is not ready for review. Thank you for the feedback I will reach out again once it is ready. I might have mixed up with this one #15946 when I flagged it as ready |
|
No worries, happy to review when it is ready! |
Description
Fixes # (issue)
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change