use test environments for codegen tests #15884
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-04-15) |
tgummerer
added
the
impact/no-changelog-required
This was referenced Apr 9, 2024
Currently these tests always just use the directory in the repository tree to run. This isn't great for a couple of reasons: - The tests write files into the repo tree (these are .gitignored, but still large and aren't cleaned up after the test finished) - Tests running in parallel can potentially use the same directory. We have a nice helper that creates new test environments and cleans them up at the end of the tests. Use that here for more test isolation. Also remove the t.Run() in the inner loop. For a lot of these tests it's not possible to run only one bit at a time (which is also why there is an ordering enforced). It's better to just make them run in the outer test loop to avoid confusion when trying to rerun only part of the test.
tgummerer
force-pushed
the
tg/codegen-tests-use-environments
branch
from
3a33af2
to
3b0b261
Compare
This was referenced Apr 10, 2024
Frassle
reviewed
Apr 10, 2024
| @@ -574,8 +585,8 @@ func TestSDKCodegen(t *testing.T, opts *SDKCodegenOptions) { // revive:disable-l | |||
| files, err := GeneratePackageFilesFromSchema(schemaPath, opts.GenPackage) | |||
| require.NoError(t, err) | |||
|
|
|||
| if !RewriteFilesWhenPulumiAccept(t, dirPath, opts.Language, files) { | |||
| expectedFiles, err := LoadBaseline(dirPath, opts.Language) | |||
| if !RewriteFilesWhenPulumiAccept(t, e.CWD, opts.Language, files) { | |||
There was a problem hiding this comment.
Doesn't this break the PULUMI_ACCEPT flow? Because we're going to rewrite the files in the temp dir?
There was a problem hiding this comment.
Yeah it does. We probably need to re-export these files.
The latest commit fixes that.
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently these tests always just use the directory in the repository tree to run. This isn't great for a couple of reasons:
We have a nice helper that creates new test environments and cleans them up at the end of the tests. Use that here for more test isolation.
Also remove the t.Run() in the inner loop. For a lot of these tests it's not possible to run only one bit at a time (which is also why there is an ordering enforced). It's better to just make them run in the outer test loop to avoid confusion when trying to rerun only part of the test.
(I originally noticed this for the Bazel hackathon project. Bazel only creates symlinks to files and then the
yarn installcreates the node_modules folder within that folder with the symlinks. However tsc then looks for the node_modules folder in the folder the symlink of the source files point to. So that's an ulterior motive for this change, but I think the cleanup is worth it either way)