feat: Package Schema resource-typed properties #15795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFriel
added
the
impact/no-changelog-required
Changelog[uncommitted] (2024-04-30)Features
|
AaronFriel
removed
the
impact/no-changelog-required
AaronFriel
force-pushed
the
friel/any-resource-pt-2
branch
from
130897d
to
fbf8cac
Compare
justinvp
reviewed
Mar 27, 2024
Frassle
reviewed
Mar 27, 2024
Zaid-Ajaj
reviewed
Mar 27, 2024
AaronFriel
force-pushed
the
friel/any-resource-pt-2
branch
from
dc66e68
to
8cd0a87
Compare
|
I tested this feature branch (which also contains the unmarshaling fix) with the pulumi-kubernetes provider and it seems to work really well. Here's the patch that I applied: Then I updated my example (note the func signature in ApplyT now uses uid := example.Resources.Index(pulumi.Int(0)).ApplyT(func(r pulumi.Resource) pulumi.StringPtrOutput {
ctx.Log.Info("I'm a good ConfigMap", &pulumi.LogArgs{Resource: r})
configMap := r.(*corev1.ConfigMap)
return configMap.Metadata.Uid()
})
ctx.Export("configMapUid", uid)And the results were as-expected: |
EronWright
reviewed
Apr 8, 2024
This was referenced Apr 9, 2024
EronWright
reviewed
Apr 11, 2024
Comment on lines
74
to
+75
| case anyResourceType: | ||
| fallthrough | ||
| return "pulumi:pulumi:Resource" |
There was a problem hiding this comment.
I think we need this block to be above the jsonType, or jsonType should stop leaning on fallthrough.
AaronFriel
force-pushed
the
friel/any-resource-pt-2
branch
from
b0aa1ba
to
c20c3d1
Compare
A new built-in type, `pulumi.json#/Resource` is added to the schema to refer to
any resource. This unblocks schematizing resources like
`kubernetes.yaml/v2.ConfigFile`, which ideally would declare an output like so:
```json
"properties": {
"resources": {
"type": "array",
"items": {
"$ref": "pulumi.json#/Resource"
},
"description": "Resources created by the ConfigFile."
}
},
```
This is a small ergonomic improvement over `pulumi.json#/Any`, and fixes #6346.
This moves more of the Resource type's implementation to the generated `types_builins.go`.
This PR unblocks the integration test below, which modified the Echo provider to pass-through its inputs to outputs - including resources. There remains a bug in re-marshaling a resource inside a provider that we avoid by simplifying `Create()` to pass-through. This is or is related to #15788.
Co-authored-by: Eron Wright <eron@pulumi.com>
AaronFriel
force-pushed
the
friel/any-resource-pt-2
branch
from
c20c3d1
to
5c29970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new built-in type,
pulumi.json#/Resourceis added to the schema to refer to any resource. This unblocks schematizing resources likekubernetes.yaml/v2.ConfigFile, which ideally would declare an output like so:This is a small ergonomic improvement over
pulumi.json#/Any, and fixes #6346.