Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass --no-audit to npm install during pulumi new #1388

Merged
merged 1 commit into from
May 18, 2018

Conversation

ellismg
Copy link
Contributor

@ellismg ellismg commented May 18, 2018

While we wait for upstream to fix the security issue, we'll just pass
--no-audit to npm install when creating a new project. Since the
warning is against an indirect dependency of @pulumi/pulumi, we can't
actually address the issue ourselves.

Mitigates #1350

While we wait for upstream to fix the security issue, we'll just pass
`--no-audit` to `npm install` when creating a new project. Since the
warning is against an indirect dependency of @pulumi/pulumi, we can't
actually address the issue ourselves.

Mitigates #1350
@ellismg
Copy link
Contributor Author

ellismg commented May 18, 2018

I used nvm to try this with both 6.10.2 and 8.11.2. The former does not have any audit stuff, but ignores the --no-audit flag.

@ellismg
Copy link
Contributor Author

ellismg commented May 18, 2018

/cc @joeduffy @mehzer

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ellismg!

Copy link
Contributor

@swgillespie swgillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellismg ellismg merged commit d11acf5 into master May 18, 2018
@pgavlin pgavlin deleted the ellismg/pass-no-audit branch June 12, 2018 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants