Support clones from Azure DevOps #12001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-02-02)Bug Fixes
|
|
By the way, |
Frassle
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
We also have some workaround logic in the CLI for dealing with azure repos. It's a bit sad we're having to duplicate fixes like this, long term goal is to not have each auto library do logic like this but eh long term goals. Short term, I'd guess we could copy this logic to the CLI now instead of the shelling out to system git logic that we currently have?
Try running |
|
Looks like we need two actions to get this in:
|
squaremo
force-pushed
the
update-go-git-azdevops
branch
from
90be714
to
f75b531
Compare
In general, go-git can't clone from Azure DevOps, because the latter requires the capabilities multi_ack and multi_ack_detailed, which aren't implemented. However, there's now a workaround, which boils down to this: pretend, for the initial clone, that those capabilities _are_ supported, and expect them not to be used. (See go-git/go-git#613 for more on this workaround.) Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>
./scripts/tidy.sh Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>
Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>
squaremo
force-pushed
the
update-go-git-azdevops
branch
from
a648051
to
7843de3
Compare
|
@squaremo did you make the changes to |
Yes; this is the line that makes the intended change to go.mod: Other changes to |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 4, 2023
9159: Add --insecure option to `pulumi login` r=justinvp a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Add --insecure option to `pulumi login` which disables https certificate checks. Fixes #9120 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have updated the [CHANGELOG-PENDING](https://github.com/pulumi/pulumi/blob/master/CHANGELOG_PENDING.md) file with my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 12001: Support clones from Azure DevOps r=RobbieMcKinstry a=squaremo In general, go-git can't clone from Azure DevOps, because the latter requires the capabilities multi_ack and multi_ack_detailed, which aren't implemented. However, there's now a workaround, which boils down to this: pretend, for the initial clone, that those capabilities _are_ supported, and expect them not to be used. (See go-git/go-git#613 for more on this workaround.) I tried this with a personal Azure DevOps account; an automated test would need either a reliably long-lived Azure DevOps repo, or a test server that can mimic Azure DevOps' particular capabilities. I'm open to suggestions! 12025: [sdks/go] Delegate alias computation to the engine r=abhinav a=Zaid-Ajaj Fixes #11066 Addresses #11697 Credit to `@abhinav` for making aliases unit-testable by intercepting `RegisterResource` calls. > I did change the test slightly so that it either checks for `AliasURNs: []string` or `Aliases: []*pulumirpc.Alias` because I've made it such that one of them is `nil` depending on `supportsAliasSpecs` ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Fraser Waters <fraser@pulumi.com> Co-authored-by: Michael Bridgen <mbridgen@pulumi.com> Co-authored-by: Zaid Ajaj <zaid.naom@gmail.com>
|
Build failed (retrying...): |
|
Build succeeded: |
squaremo
added a commit
to pulumi/pulumi-kubernetes-operator
that referenced
this pull request
Feb 14, 2023
3.54.0 contains the fix for cloning Azure DevOps repos:
pulumi/pulumi#12001
The base image change is not strictly needed, but keeping it current
with the SDK version seems like a good idea. (The automated bumps don't
do this).
Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>
squaremo
added a commit
to pulumi/pulumi-kubernetes-operator
that referenced
this pull request
Feb 15, 2023
3.55.0 contains the fix for cloning Azure DevOps repos:
pulumi/pulumi#12001
The base image change is not strictly needed, but keeping it current
with the SDK version seems like a good idea. (The automated bumps don't
do this).
Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>
squaremo
added a commit
to pulumi/pulumi-kubernetes-operator
that referenced
this pull request
Feb 15, 2023
* Bump Pulumi SDK version and base image to 3.55.0
3.55.0 contains the fix for cloning Azure DevOps repos:
pulumi/pulumi#12001
The base image change is not strictly needed, but keeping it current
with the SDK version seems like a good idea. (The automated bumps don't
do this). NB the _least_ recent release that contains the fix is 3.54.0, but
there is no Docker image for it.
* Add changelog entry for version bump
---------
Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, go-git can't clone from Azure DevOps, because the latter requires the capabilities multi_ack and multi_ack_detailed, which aren't implemented. However, there's now a workaround, which boils down to this: pretend, for the initial clone, that those capabilities are supported, and expect them not to be used.
(See go-git/go-git#613 for more on this workaround.)
I tried this with a personal Azure DevOps account; an automated test would need either a reliably long-lived Azure DevOps repo, or a test server that can mimic Azure DevOps' particular capabilities. I'm open to suggestions!