Revert "Revert "Simplified invokes: SDK-gen and program-gen implementation for dotnet and nodejs"" #11753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-01-11)Features
|
Zaid-Ajaj
force-pushed
the
revert-11701-revert-11418-simplified-invoke-gen
branch
2 times, most recently
from
01dd25d
to
d0813e6
Compare
|
@Zaid-Ajaj Can you highlight the difference between #11418 and #11753? Are the only changes in |
Zaid-Ajaj
commented
Jan 9, 2023
| // indicates a logical bug in our marshaling code. | ||
| return nil, diags, fmt.Errorf("error binding outputs for function %v: invalid return type", token) | ||
| } | ||
| } else if spec.Outputs != nil { |
There was a problem hiding this comment.
@iwahbe This check here is the main difference. This is the new code block
if spec.ReturnType != nil && spec.Outputs == nil {
// bind from return type
} else if spec.Outputs != nil {
// bind from spec.Outputs
}whereas before it was only:
if spec.ReturnType != nil {
// bind from return type
}Which caused the issue that @danielrbradley had where spec.Outputs was specified by code, not through JSON/YAML parsing and didn't bind correctly.
I've also added a test to show that this actually works: Function.ReturnType being bound when FunctionSpec.Outputs is specified.
iwahbe
approved these changes
Jan 9, 2023
Zaid-Ajaj
force-pushed
the
revert-11701-revert-11418-simplified-invoke-gen
branch
2 times, most recently
from
8317bd8
to
c24fd69
Compare
danielrbradley
requested changes
Jan 10, 2023
Zaid-Ajaj
force-pushed
the
revert-11701-revert-11418-simplified-invoke-gen
branch
2 times, most recently
from
5e834a9
to
e1f5e0a
Compare
Zaid-Ajaj
force-pushed
the
revert-11701-revert-11418-simplified-invoke-gen
branch
3 times, most recently
from
13280a4
to
fe98ef9
Compare
danielrbradley
approved these changes
Jan 11, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 11, 2023
11753: Revert "Revert "Simplified invokes: SDK-gen and program-gen implementation for dotnet and nodejs"" r=Zaid-Ajaj a=Zaid-Ajaj Reverts #11701 and fixes the problem which caused the issue in the first place: - Binding `Outputs` field from `FunctionSpec` into `Function.ReturnType` when available - Adding a test that verifies the above works as expected Co-authored-by: Zaid Ajaj <zaid.naom@gmail.com>
|
Build failed: |
Zaid-Ajaj
force-pushed
the
revert-11701-revert-11418-simplified-invoke-gen
branch
from
fe98ef9
to
caadcfe
Compare
Zaid-Ajaj
force-pushed
the
revert-11701-revert-11418-simplified-invoke-gen
branch
from
0015f84
to
330676a
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 11, 2023
11753: Revert "Revert "Simplified invokes: SDK-gen and program-gen implementation for dotnet and nodejs"" r=Zaid-Ajaj a=Zaid-Ajaj Reverts #11701 and fixes the problem which caused the issue in the first place: - Binding `Outputs` field from `FunctionSpec` into `Function.ReturnType` when available - Adding a test that verifies the above works as expected Co-authored-by: Zaid Ajaj <zaid.naom@gmail.com>
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11701 and fixes the problem which caused the issue in the first place:
Outputsfield fromFunctionSpecintoFunction.ReturnTypewhen available