Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSONMarshal to go sdk #11609

Merged
merged 1 commit into from Dec 10, 2022
Merged

Add JSONMarshal to go sdk #11609

merged 1 commit into from Dec 10, 2022

Commits on Dec 9, 2022

  1. Add JSONMarshal to go sdk

    This is not as useful for Go as it is for other languages, but it's
    consistent and it saves an Apply call.
    
    Ideally we would handle nested Output types during marshalling, but to
    do that correctly we need some way to get access to
    per-call-to-JSONMarshal flags to note if we see any unknowns, or
    secrets.
    
    Go just (AFAIK) have any way to support doing that.
    
    So we do the next best thing which is we at least error that nested
    Outputs can't be marshalled. Note that the `Output` interface doesn't
    embed the `Marshal` interface because there _may_ be users who have
    wrote their own `Output` types and that would be a breaking change.
    Frassle committed Dec 9, 2022
    Copy the full SHA
    9ca4627 View commit details
    Browse the repository at this point in the history