Update Pulumi codegen to net6.0 #11543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-01-04)Features
|
|
Do not merge, we'll move this to the new dotnet sdk and merge it that side. |
aq17
force-pushed
the
fraser/rmdotnetcore31
branch
from
9065f47
to
d100e5c
Compare
|
What are the benefits of doing it and downsides of keeping 3.1? Just curious. |
Benefit is if anyone is still targeting 3.1 they could keep building against Pulumi. Downside is it limits the api area of dotnet we can use (there's quite a few useful things added in 6.0). |
That's interesting. Any concrete enhancements that you have in mind that we can apply now? |
Not of the top of my head. I know it's been something I've hit a few times in the past doing dotnet changes, generally just small stuff that could be worked around. |
Frassle
added a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Dec 15, 2022
.NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well. This updates the core porjects to only 6.0 as well. We'll still want to do pulumi/pulumi#11543 in pu/pu to update sdkgen.
.NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targetting only 6.0 for a while now as well. This updates sdkgen to only 6.0 as well.
Frassle
force-pushed
the
fraser/rmdotnetcore31
branch
from
d100e5c
to
0c38cb6
Compare
Frassle
changed the title
Frassle
added a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Dec 19, 2022
.NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well. This updates the core porjects to only 6.0 as well. We'll still want to do pulumi/pulumi#11543 in pu/pu to update sdkgen.
Frassle
added a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Dec 19, 2022
.NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well. This updates the core porjects to only 6.0 as well. We'll still want to do pulumi/pulumi#11543 in pu/pu to update sdkgen.
Frassle
added a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Dec 22, 2022
.NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well. This updates the core porjects to only 6.0 as well. We'll still want to do pulumi/pulumi#11543 in pu/pu to update sdkgen.
Frassle
added a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Dec 22, 2022
.NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well. This updates the core porjects to only 6.0 as well. We'll still want to do pulumi/pulumi#11543 in pu/pu to update sdkgen.
Frassle
added a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Dec 28, 2022
.NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well. This updates the core porjects to only 6.0 as well. We'll still want to do pulumi/pulumi#11543 in pu/pu to update sdkgen.
kpitzen
reviewed
Jan 4, 2023
kpitzen
approved these changes
Jan 4, 2023
net6 can reference net3.1
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 4, 2023
11543: Update Pulumi codegen to net6.0 r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> .NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well. This updates sdkgen to only 6.0 as well. We'll need to ensure the version number in pkg/codegen/dotnet/gen.go matches the version number that pulumi/pulumi-dotnet#10 release as. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 11766: Changelog and go.mod updates for v3.51.0 r=pulumi-bot a=pulumi-bot bors merge Co-authored-by: Fraser Waters <fraser@pulumi.com> Co-authored-by: github-actions <github-actions@github.com>
|
Canceled. |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 4, 2023
11543: Update Pulumi codegen to net6.0 r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> .NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well. This updates sdkgen to only 6.0 as well. We'll need to ensure the version number in pkg/codegen/dotnet/gen.go matches the version number that pulumi/pulumi-dotnet#10 release as. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 11766: Changelog and go.mod updates for v3.51.0 r=pulumi-bot a=pulumi-bot bors merge Co-authored-by: Fraser Waters <fraser@pulumi.com> Co-authored-by: github-actions <github-actions@github.com>
Frassle
force-pushed
the
fraser/rmdotnetcore31
branch
from
4e8abe3
to
290d0fc
Compare
|
Canceled. |
|
bors merge |
|
Build succeeded:
|
bors bot
added a commit
that referenced
this pull request
Jan 10, 2023
11818: Revert "Update Pulumi codegen to net6.0" r=t0yv0 a=t0yv0 Reverts #11543 After discussing with `@danielrbradley` the providers ecosystem is not ready for releasing this yet, as auto-merge workflows will blow up providers CI. Tracking merging pre-requisites first in https://github.com/pulumi/home/issues/2531 which will unblock this. Co-authored-by: Anton Tayanovskyy <anton.tayanovskyy@gmail.com>
bors bot
added a commit
that referenced
this pull request
Jan 10, 2023
11818: Revert "Update Pulumi codegen to net6.0" r=t0yv0 a=t0yv0 Reverts #11543 After discussing with `@danielrbradley` the providers ecosystem is not ready for releasing this yet, as auto-merge workflows will blow up providers CI. Tracking merging pre-requisites first in https://github.com/pulumi/home/issues/2531 which will unblock this. Co-authored-by: Anton Tayanovskyy <anton.tayanovskyy@gmail.com>
bors bot
added a commit
that referenced
this pull request
Jan 11, 2023
11818: Revert "Update Pulumi codegen to net6.0" r=t0yv0 a=t0yv0 Reverts #11543 After discussing with `@danielrbradley` the providers ecosystem is not ready for releasing this yet, as auto-merge workflows will blow up providers CI. Tracking merging pre-requisites first in https://github.com/pulumi/home/issues/2531 which will unblock this. Co-authored-by: Anton Tayanovskyy <anton.tayanovskyy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.NET Core 3.1 is out of support on December 13th:
https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core
We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well.
This updates sdkgen to only 6.0 as well.
We'll need to ensure the version number in pkg/codegen/dotnet/gen.go matches the version number that pulumi/pulumi-dotnet#10 release as.
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change