Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't import types referenced from local variables #11442

Merged
merged 1 commit into from Nov 24, 2022

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Nov 23, 2022

Don't import types if the type is only referenced in a scoped traversal (foo.bar), not named directly.

Part of #11427
Relates to #8324

@iwahbe iwahbe added language/go impact/no-changelog-required This issue doesn't require a CHANGELOG update area/codegen SDK-gen, program-gen, convert labels Nov 23, 2022
@iwahbe iwahbe added this to the 0.81 milestone Nov 23, 2022
@iwahbe iwahbe self-assigned this Nov 23, 2022
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-11-23)

@iwahbe
Copy link
Member Author

iwahbe commented Nov 23, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 24, 2022

Build succeeded:

@bors bors bot merged commit d6b79be into master Nov 24, 2022
@pulumi-bot pulumi-bot deleted the iwahbe/go-dont-import-scoped-traversals branch November 24, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen SDK-gen, program-gen, convert impact/no-changelog-required This issue doesn't require a CHANGELOG update language/go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants