Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps grpcio to version 1.50 #11431

Merged
merged 1 commit into from Dec 21, 2022
Merged

Bumps grpcio to version 1.50 #11431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/pending/20221122--sdk-python--bumps-grpcio-to-1-50.yaml
View file
Open in desktop
@@ -0,0 +1,4 @@
changes:
- type: chore
scope: sdk/python
description: Bumps grpcio to 1.50
2 changes: 1 addition & 1 deletion proto/.checksum.txt
View file
Open in desktop
@@ -1,4 +1,4 @@
283055245 2069 proto/build-container/Dockerfile
3850377987 2069 proto/build-container/Dockerfile
3003861496 625 proto/build-container/scripts/install-go.sh
853251015 873 proto/build-container/scripts/install-node.sh
2003827277 549 proto/build-container/scripts/install-packages.sh
Expand Down
4 changes: 2 additions & 2 deletions proto/build-container/Dockerfile
View file
Open in desktop
Expand Up @@ -54,6 +54,6 @@ RUN PROTOC_VERSION=3.20.1 \
PROTOC_GEN_GO_VERSION=1.5.2 \
NODEJS_GRPC_VERSION=1.24.2 \
NODEJS_GRPC_TOOLS_VERSION=1.8.1 \
PYTHON_GRPCIO_VERSION=1.49.1 \
PYTHON_GRPCIO_TOOLS_VERSION=1.49.1 \
PYTHON_GRPCIO_VERSION=1.50.0 \
PYTHON_GRPCIO_TOOLS_VERSION=1.50.0 \
/build-scripts/install-protobuf-tools.sh
2 changes: 1 addition & 1 deletion sdk/python/lib/setup.py
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ def readme():
# Keep this list in sync with Pipfile
install_requires=[
'protobuf~=4.21',
'grpcio==1.47',
'grpcio==1.50',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: Does this need to be == pinned? >= should work, I think, and 1.51 is already released.

Example of >= pinning: https://github.com/googleapis/python-api-core/pull/466/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R42.

(Great to see this change happening)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be ~= like the other dependencies here, but I think we're a bit less keen on that for grpcio because we've had multiple cases of them releasing bad versions and all our pipelines breaking because of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that version 1.51 has already been yanked, so likely would have caused issues.

'dill~=0.3',
'six~=1.12',
'semver~=2.8',
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/requirements.txt
View file
Open in desktop
@@ -1,7 +1,7 @@
# Packages needed by the library.
# Keep this list in sync with setup.py.
protobuf~=4.21
grpcio==1.47
grpcio==1.50
dill~=0.3
six~=1.12
semver~=2.8
Expand Down