Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default answer for AskOne prompt #11354

Merged
merged 1 commit into from Nov 15, 2022
Merged

Fix default answer for AskOne prompt #11354

merged 1 commit into from Nov 15, 2022

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Nov 15, 2022

Description

Fixes #11334

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@Frassle Frassle requested a review from aq17 November 15, 2022 11:30
@pulumi-bot
Copy link
Contributor

pulumi-bot commented Nov 15, 2022

Changelog

[uncommitted] (2022-11-15)

Bug Fixes

  • [cli] Fix stack selection prompt.
    #11354

Copy link
Contributor

@aq17 aq17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Frassle
Copy link
Member Author

Frassle commented Nov 15, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 15, 2022

Build succeeded:

@bors bors bot merged commit 972e1e8 into master Nov 15, 2022
@bors bors bot deleted the fraser/fixAskPrompt branch November 15, 2022 14:04
@aq17 aq17 mentioned this pull request Nov 18, 2022
3 tasks
bors bot added a commit that referenced this pull request Nov 18, 2022
11408: Fix stack selection behavior r=aq17 a=aq17

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

Fixes #11407 
Follow on to PR [11354](#11354). When we don't prompt to `create a new stack`, we should default to an existing stack so the empty string isn't populated.

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: aq17 <aqiu@pulumi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulumi stack select broke after update to v3.46.1
3 participants