Regenerate .pyi files, sort diffs on proto cksum #11313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-11-10) |
Frassle
approved these changes
Nov 9, 2022
iwahbe
added
the
impact/no-changelog-required
We do, The test was fine, the issue cam up because of a mac specific weirdness with |
iwahbe
force-pushed
the
iwahbe/regenerate-proto-for-python
branch
3 times, most recently
from
8e101d5
to
d0982c6
Compare
iwahbe
force-pushed
the
iwahbe/regenerate-proto-for-python
branch
from
d0982c6
to
eecbe29
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerate the .pyi files as left from #11095.
It's unclear to me why this didn't happen in the initial PR. The only thing I can think of is that .checksum.txt was manually edited.