feat: sign pulumi binaries with cosign #11283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
Changelog[uncommitted] (2022-11-09)Features
|
AaronFriel
reviewed
Nov 8, 2022
|
/run-acceptance-tests |
|
@dirien fyi, if you create a branch on the repo instead of a PR from your fork, we'll run acceptance tests automatically. Fork PR tests have to be run manually because they open us up to risk if we run them automatically, it's an ongoing challenge to ensure the secrets are locked down & inaccessible to contributor PRs. |
|
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
|
Here it goes further #11310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds cosign to the build process of the Pulumi binaries. I changed the pipeline so cosign can sign without keys by authenticating with OIDC. GitHub supports this.
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change