Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeletedWith resource option #11095

Merged
merged 8 commits into from Nov 4, 2022
Merged

Add DeletedWith resource option #11095

merged 8 commits into from Nov 4, 2022

Commits on Oct 31, 2022

  1. Add DeletedWith resource option

    In many cases there is no need to delete resources if the container
    resource is going to be deleted as well.
    
    A few examples:
     * Database object (roles, tables) when database is being deleted
     * Cloud IAM bindings when user itself is being deleted
    
    This helps with:
     * Speeding the deletion process
     * Removing unnecessary calls to providers
     * Avoiding failed deletions when the pulumi user running the
       plan has access to the container resource but not the contained
       ones
    
    To avoid deleting contained resources, set the `DeletedWith` resource
    option to the container resource.
    
    TODO:
     Should we support DeletedWith with PendingDeletes?
     Special case might be when the contained resource is marked as pending
     deletion but we now want to delete the container resource, so
     ultimately there is no need to delete the contained anymore
    same-id committed Oct 31, 2022
    Copy the full SHA
    4bbe365 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Copy the full SHA
    db02881 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    40c0b80 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Add missing ;

    Frassle committed Nov 4, 2022
    Copy the full SHA
    4b68325 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    d3b94aa View commit details
    Browse the repository at this point in the history
  3. Fix some lint issues

    Frassle committed Nov 4, 2022
    Copy the full SHA
    6a8275b View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    7279aa0 View commit details
    Browse the repository at this point in the history
  5. Format python

    Frassle committed Nov 4, 2022
    Copy the full SHA
    b4a2f2b View commit details
    Browse the repository at this point in the history