Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce types output #10831

Merged
merged 16 commits into from Nov 11, 2022
Merged

Reduce types output #10831

merged 16 commits into from Nov 11, 2022
+1,322 −195

Commits on Nov 11, 2022

  1. Split types/inputs.ts and types/outputs.ts 

    This commit splits the Input and Output (IO) definitions
into a collection of files instead of just two total files.
Now, each mod gets its own directory under /types which exposes
index.ts, output.ts, and input.ts files. By splitting up defintions,
we reduce the amount of memory needed to lookup the type definition
for a single type -- previously, we had to load every type in the
package just to read a single type.
    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    d9a0cc7 View commit details
    Browse the repository at this point in the history

  2. Refactor getRelativePath, remove comments

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    e40a650 View commit details
    Browse the repository at this point in the history

  3. Prevent collision in type decl

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    4c9735c View commit details
    Browse the repository at this point in the history

  4. Fix namespace nesting.

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    dc082aa View commit details
    Browse the repository at this point in the history

  5. Split writes across files

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    d3acb48 View commit details
    Browse the repository at this point in the history

  6. Revert change about splitting type writing

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    4de553d View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary boolean guard

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    4c9075c View commit details
    Browse the repository at this point in the history

  8. Update codegen tests

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    87b986a View commit details
    Browse the repository at this point in the history

  9. Remove re-exports from the index

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    9235b9f View commit details
    Browse the repository at this point in the history

  10. Import only specific child file based on parent type.

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    39ad793 View commit details
    Browse the repository at this point in the history

  11. Regenerate codegen tests

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    9219fc0 View commit details
    Browse the repository at this point in the history

  12. Add a special case for imports, reset codegen tests

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    1d7e9ae View commit details
    Browse the repository at this point in the history

  13. Update pkg/codegen/nodejs/gen.go 

    Co-authored-by: Kyle Pitzen <kyle.pitzen@gmail.com>
    @RobbieMcKinstry @kpitzen
    RobbieMcKinstry and kpitzen committed Nov 11, 2022
    Copy the full SHA
    f0b3513 View commit details
    Browse the repository at this point in the history

  14. Convert mod.utilities from a method to a function.

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    59e583b View commit details
    Browse the repository at this point in the history

  15. Add new acceptance test for nodejs tsconfig path aliasing

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    9fb2da3 View commit details
    Browse the repository at this point in the history

  16. Regen code with consistent spacing in tsconfig

    @RobbieMcKinstry
    RobbieMcKinstry committed Nov 11, 2022
    Copy the full SHA
    a07a250 View commit details
    Browse the repository at this point in the history