Skip to content

Commit

Permalink
Merge #11431 #11704
Browse files Browse the repository at this point in the history
11431: Bumps grpcio to version 1.50 r=kpitzen a=kpitzen

Currently, pinning to a version of grpcio <1.50 can cause build errors on newer versions of python+pip - the existing setup.py install method of building libararies is being deprecated and wheels are not being backported for older versions of grpcio.  Since this change is a no-op as far as our python proto clients are concerned, it feels safe to bump to a version that will be supported going forward

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

Fixes #11276 

Though this change doesn't result in guaranteed Python 3.11 support, it should allow users of Python 3.11 to at least install Pulumi successfully without Deprecation warnings etc.  grpcio 1.4X does not ship 3.11-compatible wheels, so users are starting to see errors when installing Pulumi - bumping to this version also does not change our existing proto clients in Python, so feels like a relatively safe change.

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


11704: ci: Freeze v3.50.1 for release r=iwahbe a=iwahbe



Co-authored-by: Kyle Pitzen <kyle.pitzen@gmail.com>
Co-authored-by: Ian Wahbe <ian@wahbe.com>
  • Loading branch information
3 people committed Dec 21, 2022
3 parents 818d055 + 0752b79 + ea101e3 commit ee357dd
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .version
@@ -1 +1 @@
3.50.1
3.50.2
@@ -0,0 +1,4 @@
changes:
- type: chore
scope: sdk/python
description: Bumps grpcio to 1.50
2 changes: 1 addition & 1 deletion proto/.checksum.txt
@@ -1,4 +1,4 @@
283055245 2069 proto/build-container/Dockerfile
3850377987 2069 proto/build-container/Dockerfile
3003861496 625 proto/build-container/scripts/install-go.sh
853251015 873 proto/build-container/scripts/install-node.sh
2003827277 549 proto/build-container/scripts/install-packages.sh
Expand Down
4 changes: 2 additions & 2 deletions proto/build-container/Dockerfile
Expand Up @@ -54,6 +54,6 @@ RUN PROTOC_VERSION=3.20.1 \
PROTOC_GEN_GO_VERSION=1.5.2 \
NODEJS_GRPC_VERSION=1.24.2 \
NODEJS_GRPC_TOOLS_VERSION=1.8.1 \
PYTHON_GRPCIO_VERSION=1.49.1 \
PYTHON_GRPCIO_TOOLS_VERSION=1.49.1 \
PYTHON_GRPCIO_VERSION=1.50.0 \
PYTHON_GRPCIO_TOOLS_VERSION=1.50.0 \
/build-scripts/install-protobuf-tools.sh
2 changes: 1 addition & 1 deletion sdk/python/lib/setup.py
Expand Up @@ -45,7 +45,7 @@ def readme():
# Keep this list in sync with Pipfile
install_requires=[
'protobuf~=4.21',
'grpcio==1.47',
'grpcio==1.50',
'dill~=0.3',
'six~=1.12',
'semver~=2.8',
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/requirements.txt
@@ -1,7 +1,7 @@
# Packages needed by the library.
# Keep this list in sync with setup.py.
protobuf~=4.21
grpcio==1.47
grpcio==1.50
dill~=0.3
six~=1.12
semver~=2.8
Expand Down

0 comments on commit ee357dd

Please sign in to comment.