Interpret schema.Asset as pcl.AssetOrArchive

pulumi · Dec 8, 2022 · 8e99749 · 8e99749
1 parent 833c85a
commit 8e99749
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/changelog/pending/20221208--programgen--interpret-schema-asset-as-pcl-assetorarchive.yaml b/changelog/pending/20221208--programgen--interpret-schema-asset-as-pcl-assetorarchive.yaml
@@ -0,0 +1,4 @@
+changes:
+- type: fix
+  scope: programgen
+  description: Interpret schema.Asset as pcl.AssetOrArchive.
diff --git a/pkg/codegen/pcl/binder_schema.go b/pkg/codegen/pcl/binder_schema.go
@@ -389,7 +389,11 @@ func (b *binder) schemaTypeToType(src schema.Type) model.Type {
 		case schema.ArchiveType:
 			return ArchiveType
 		case schema.AssetType:
-			return AssetType
+			// Generated SDK code accepts assets or archives when schema.AssetType is
+			// specified. In an effort to keep PCL type checking in sync with our
+			// generated SDKs, we match the SDKs behavior when translating schema types to
+			// PCL types.
+			return AssetOrArchiveType
 		case schema.JSONType:
 			fallthrough
 		case schema.AnyType:

diff --git a/pkg/codegen/testing/test/program_driver.go b/pkg/codegen/testing/test/program_driver.go
@@ -249,7 +249,6 @@ var PulumiPulumiYAMLProgramTests = []ProgramTest{
 		Directory:   transpiled("azure-app-service"),
 		Description: "Azure App Service",
 		Skip:        codegen.NewStringSet("go", "dotnet"),
-		BindOptions: []pcl.BindOption{pcl.SkipResourceTypechecking},
 	},
 	{
 		Directory:   transpiled("azure-container-apps"),