Skip to content

Commit

Permalink
Bumps grpcio to version 1.50
Browse files Browse the repository at this point in the history
Currently, pinning to a version of grpcio <1.50 can cause build errors
on newer versions of python+pip - the existing setup.py install method
of building libararies is being deprecated and wheels are not being
backported for older versions of grpcio.  Since this change is a no-op
as far as our python proto clients are concerned, it feels safe to bump
to a version that will be supported going forward
  • Loading branch information
Kyle Pitzen authored and Kyle Pitzen committed Nov 29, 2022
1 parent 45dddd8 commit 005bae9
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 5 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Expand Up @@ -272,6 +272,7 @@ jobs:
fail-fast: ${{ contains(needs.matrix.outputs.integration-test-matrix, 'macos') }}
matrix: ${{ fromJson(needs.matrix.outputs.integration-test-matrix) }}
uses: ./.github/workflows/ci-run-test.yml
timeout-minutes: 3600
with:
ref: ${{ inputs.ref }}
version: ${{ inputs.version }}
Expand Down
@@ -0,0 +1,4 @@
changes:
- type: chore
scope: sdk/python
description: Bumps grpcio to 1.50
2 changes: 1 addition & 1 deletion proto/.checksum.txt
@@ -1,4 +1,4 @@
283055245 2069 proto/build-container/Dockerfile
3850377987 2069 proto/build-container/Dockerfile
3003861496 625 proto/build-container/scripts/install-go.sh
853251015 873 proto/build-container/scripts/install-node.sh
2003827277 549 proto/build-container/scripts/install-packages.sh
Expand Down
4 changes: 2 additions & 2 deletions proto/build-container/Dockerfile
Expand Up @@ -54,6 +54,6 @@ RUN PROTOC_VERSION=3.20.1 \
PROTOC_GEN_GO_VERSION=1.5.2 \
NODEJS_GRPC_VERSION=1.24.2 \
NODEJS_GRPC_TOOLS_VERSION=1.8.1 \
PYTHON_GRPCIO_VERSION=1.49.1 \
PYTHON_GRPCIO_TOOLS_VERSION=1.49.1 \
PYTHON_GRPCIO_VERSION=1.50.0 \
PYTHON_GRPCIO_TOOLS_VERSION=1.50.0 \
/build-scripts/install-protobuf-tools.sh
2 changes: 1 addition & 1 deletion sdk/python/lib/setup.py
Expand Up @@ -45,7 +45,7 @@ def readme():
# Keep this list in sync with Pipfile
install_requires=[
'protobuf~=4.21',
'grpcio==1.47',
'grpcio==1.50',
'dill~=0.3',
'six~=1.12',
'semver~=2.8',
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/requirements.txt
@@ -1,7 +1,7 @@
# Packages needed by the library.
# Keep this list in sync with setup.py.
protobuf~=4.21
grpcio==1.47
grpcio==1.50
dill~=0.3
six~=1.12
semver~=2.8
Expand Down

0 comments on commit 005bae9

Please sign in to comment.