Implement State Upgrade in the Terraform Plugin Framework #758
Conversation
|
Diff for pulumi-random with merge commit 7ff6599 |
|
Diff for pulumi-azuread with merge commit 7ff6599 |
|
Diff for pulumi-gcp with merge commit 7ff6599 |
|
Diff for pulumi-azure with merge commit 7ff6599 |
t0yv0
changed the title
|
Friendly ping @jazzyfresh - would it be possible to review? I am available for QnA if needed. |
| return &upgradedResourceState{st}, nil | ||
| } | ||
| tfType := rh.schema.Type().TerraformType(ctx).(tftypes.Object) | ||
| rawState, err := pfutils.NewRawState(tfType, st.Value) |
There was a problem hiding this comment.
could surface the error here
There was a problem hiding this comment.
Good catch! I wonder if there's a linter for unhandled errs.
|
Diff for pulumi-azuread with merge commit c167330 |
|
Diff for pulumi-random with merge commit c167330 |
|
Diff for pulumi-random with merge commit 734bab2 |
|
Diff for pulumi-azuread with merge commit 734bab2 |
|
Diff for pulumi-gcp with merge commit c167330 |
|
Diff for pulumi-gcp with merge commit 734bab2 |
|
Diff for pulumi-azure with merge commit c167330 |
|
Diff for pulumi-azure with merge commit 734bab2 |
|
Diff for pulumi-random with merge commit 3ab62fc |
|
Diff for pulumi-azuread with merge commit 3ab62fc |
|
Diff for pulumi-gcp with merge commit 3ab62fc |
|
Diff for pulumi-azure with merge commit 3ab62fc |
|
Looks like I need to fix #798 first that's not working on master, to pass the tests. |
Co-authored-by: Jasmine Dahilig <jasmine.dahilig@gmail.com>
t0yv0
force-pushed
the
t0yv0/pf-state-upgrades
branch
from
1615996
to
ad11293
Compare
|
Diff for pulumi-azuread with merge commit 1ecb728 |
|
Diff for pulumi-random with merge commit 1ecb728 |
|
Diff for pulumi-gcp with merge commit 1ecb728 |
|
Diff for pulumi-azure with merge commit 1ecb728 |
Fixes #748
This is incomplete by itself since it also needs to make sure the bridge writes out the schema version into Pulumi state. I'll add a few stacked PRs on top to demonstrate that.
Related: pulumi/pulumi-random#258 - if Random is rebuilt against this version 258 no longer reproduces.