Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail build on missing data sources, like for resources #718

Merged
merged 1 commit into from Jan 13, 2023

Conversation

thomas11
Copy link
Contributor

This PR replicates #616 but for data sources. Without this, it's deceptively easy to assume that when there are no errors, all mappings are complete, but it would only be true for resources.

@t0yv0
Copy link
Member

t0yv0 commented Jan 10, 2023

All things equal stricter seems better at this point. Thank you.

@github-actions
Copy link

Diff for pulumi-random with merge commit f757fe3

@github-actions
Copy link

Diff for pulumi-azuread with merge commit f757fe3

@github-actions
Copy link

Diff for pulumi-gcp with merge commit f757fe3

@github-actions
Copy link

Diff for pulumi-azure with merge commit f757fe3

@github-actions
Copy link

Diff for pulumi-azuread with merge commit f757fe3

@github-actions
Copy link

Diff for pulumi-random with merge commit f757fe3

@github-actions
Copy link

Diff for pulumi-gcp with merge commit f757fe3

@github-actions
Copy link

Diff for pulumi-azure with merge commit f757fe3

@github-actions
Copy link

Diff for pulumi-aws with merge commit f757fe3

@thomas11 thomas11 merged commit 1042913 into master Jan 13, 2023
@thomas11 thomas11 deleted the tkappler/fail-on-missing-datasource branch January 13, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants