Ensure forward build compatibility for resource provider #675
Conversation
AaronFriel
force-pushed
the
friel/fwd-compat
branch
from
a584790
to
69cd21e
Compare
|
Diff for pulumi-random with merge commit 553300c |
|
Diff for pulumi-azuread with merge commit 553300c |
|
Diff for pulumi-random with merge commit d5bc837 |
|
Diff for pulumi-azuread with merge commit d5bc837 |
|
Diff for pulumi-gcp with merge commit 553300c |
|
Diff for pulumi-gcp with merge commit d5bc837 |
|
Diff for pulumi-aws with merge commit 553300c |
|
Diff for pulumi-aws with merge commit d5bc837 |
AaronFriel
added
the
impact/no-changelog-required
pkg/tfgen/pluginHost.go
Outdated
| @@ -32,6 +33,8 @@ import ( | |||
| var _ = (plugin.Provider)((*inmemoryProvider)(nil)) | |||
|
|
|||
| type inmemoryProvider struct { | |||
| pulumirpc.UnimplementedResourceProviderServer | |||
There was a problem hiding this comment.
Could clean up all the panic unimplemented methods in this file
There was a problem hiding this comment.
I thought about it but I wondered if it would change the behavior in any way. The unimplemented server returns a grpc error rather than panic, yeah?
Does seem unlikely anything depends on these methods panicking.
There was a problem hiding this comment.
Yeh I think it was just an easier way to write the method, its used in a part of code that doesn't call any of this stuff anyway.
There was a problem hiding this comment.
Ah, the embedding here was incorrect anyway. I've added a PR to pu/pu to add an embeddable plugin.UnimplementedProvider: pulumi/pulumi#11618
There was a problem hiding this comment.
@Frassle updated this targeting latest Pulumi, embedded plugin.UnimplementedProvider and deleted the panicking methods.
AaronFriel
force-pushed
the
friel/fwd-compat
branch
from
69cd21e
to
9471bc2
Compare
|
Diff for pulumi-azuread with merge commit 5b769e2 |
|
Diff for pulumi-random with merge commit 5b769e2 |
|
Diff for pulumi-gcp with merge commit 5b769e2 |
|
Diff for pulumi-aws with merge commit 5b769e2 |
11618: Add forward compatible plugin.UnimplementedProvider r=AaronFriel a=AaronFriel This adds an implementation of Provider that can be embedded for forward compatibility. A question was raised in pulumi/pulumi-terraform-bridge#675 about why the PR did not delete the default panicking implementations of various methods. In doing so, I discovered the in memory provider implementation used the Pulumi SDK's `Provider` interface, not the usual gRPC server interface. With this change, we'll be able to amend the PR to the bridge to embed a long-term compatible interface. Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
AaronFriel
force-pushed
the
friel/fwd-compat
branch
from
92c6128
to
4e46f2d
Compare
|
Diff for pulumi-random with merge commit 647f0fe |
|
Diff for pulumi-azuread with merge commit 647f0fe |
|
Diff for pulumi-random with merge commit bcbc456 |
|
Diff for pulumi-azuread with merge commit bcbc456 |
|
Diff for pulumi-gcp with merge commit 647f0fe |
|
Diff for pulumi-gcp with merge commit bcbc456 |
|
Diff for pulumi-aws with merge commit 647f0fe |
|
Diff for pulumi-aws with merge commit bcbc456 |
See: pulumi/pulumi#11616