Second phase of convert mapper #654
Conversation
|
Diff for pulumi-azuread with merge commit 117632a |
|
Diff for pulumi-random with merge commit 117632a |
Frassle
force-pushed
the
fraser/convertMapper
branch
from
2907c0a
to
bfbf29f
Compare
|
Diff for pulumi-gcp with merge commit 117632a |
|
Diff for pulumi-azure with merge commit 117632a |
|
Diff for pulumi-aws with merge commit 117632a |
Frassle
force-pushed
the
fraser/convertMapper
branch
from
bfbf29f
to
4e00ee8
Compare
|
Diff for pulumi-random with merge commit 044afd9 |
|
Diff for pulumi-azuread with merge commit 044afd9 |
|
Diff for pulumi-gcp with merge commit 044afd9 |
Frassle
force-pushed
the
fraser/convertMapper
branch
from
4e00ee8
to
862f9d1
Compare
|
Diff for pulumi-azure with merge commit 044afd9 |
|
Diff for pulumi-azuread with merge commit 939598b |
|
Diff for pulumi-random with merge commit 939598b |
|
Diff for pulumi-gcp with merge commit 939598b |
|
Diff for pulumi-aws with merge commit 044afd9 |
|
Diff for pulumi-azure with merge commit 939598b |
|
Diff for pulumi-aws with merge commit 939598b |
|
Blocked on pulumi/pulumi#11452 |
| @@ -53,6 +54,15 @@ func (p *inmemoryProvider) GetSchema(version int) ([]byte, error) { | |||
| return p.schema, nil | |||
| } | |||
|
|
|||
| func (p *inmemoryProvider) GetMapping(key string) ([]byte, string, error) { | |||
| info := tfbridge.MarshalProviderInfo(&p.info) | |||
There was a problem hiding this comment.
Whoah. Is all of this needed🙏
This is a large-ish export, I need to get a bit more of a handle on all the things here to be comfortable, as presumably this now also becomes an obligation for PF-built providers to hit the same contract.
There was a problem hiding this comment.
This is not new, this is the data structure that tf2pulumi already expects for bridged providers to export for conversions. It's just currently it access it via running the plugin with the "-get-provider-info" flag (see https://github.com/pulumi/pulumi-terraform-bridge/blob/master/pkg/tfbridge/main.go#L55-L60)
This is just moving that interface to be a well known engine interface so that the engine can do the plugin lookup and loading, rather than tf2pulumi having to do it.
There was a problem hiding this comment.
Ah, gotcha so tf2pulumi consumes it. This is my miss then, I need to target supporting this from tfpf branch as well!
Frassle
force-pushed
the
fraser/convertMapper
branch
from
862f9d1
to
2c2f8ae
Compare
|
Diff for pulumi-random with merge commit 1019e19 |
|
Diff for pulumi-azuread with merge commit 1019e19 |
|
Diff for pulumi-gcp with merge commit 1019e19 |
|
Diff for pulumi-azure with merge commit 1019e19 |
|
Diff for pulumi-aws with merge commit 1019e19 |
No description provided.