Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include examples with errors #645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include examples with errors #645

wants to merge 1 commit into from

Commits on Nov 15, 2022

  1. Include examples with errors 

    We generate a huge number of examples with the majority of examples
correct.

From the perspective of `pulumi/pkg/codegen` authors, the examples that
are not correct can be split into two catagories:

1. Examples where the PCL is syntactically correct but does not describe
a valid program.

2. Examples where the PCL describes a valid program but the resulting
example is not valid.

(2) is a bug in program-gen. I think we all agree that valid PCL should
result in a valid program.

(1) is more complicated. Right now, programgen tries to produce an
output file that is as close to a valid program as possible. If it
believes the output program will not be correct, an error diagnostic
explaining why the result will not be valid is emmited with the file.

We need to decide if we want to include examples that are known to be
incorrect.
    @iwahbe
    iwahbe committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    6507991 View commit details
    Browse the repository at this point in the history