Include stacktrace in error message #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieMcKinstry
added
impact/usability
|
Diff for pulumi-azuread with merge commit 1a14099 |
|
Diff for pulumi-random with merge commit 1a14099 |
|
Diff for pulumi-gcp with merge commit 1a14099 |
|
Diff for pulumi-azure with merge commit 1a14099 |
|
Diff for pulumi-azuread with merge commit b27f01e |
|
Diff for pulumi-random with merge commit b27f01e |
|
Diff for pulumi-gcp with merge commit b27f01e |
viveklak
reviewed
Nov 9, 2022
viveklak
reviewed
Nov 9, 2022
viveklak
approved these changes
Nov 9, 2022
|
Diff for pulumi-azure with merge commit b27f01e |
|
Diff for pulumi-aws with merge commit 1a14099 |
|
Diff for pulumi-aws with merge commit b27f01e |
|
Diff for pulumi-azuread with merge commit a77884b |
|
Diff for pulumi-random with merge commit a77884b |
|
Diff for pulumi-gcp with merge commit a77884b |
|
Diff for pulumi-azure with merge commit a77884b |
|
Diff for pulumi-aws with merge commit a77884b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TFGen, HCL conversion is allowed to panic. Panics are recovered and converted into errors, which are then displayed to the user.
Currently, these panics don't provide a way to inspect the stacktrace, making it very hard to debug P1s. This PR captures the stacktrace, and logs traces when
debugis enabled.Related