Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoupdate for pulumi/pulumi #632

Merged
merged 1 commit into from Nov 11, 2022
Merged

Fix autoupdate for pulumi/pulumi #632

merged 1 commit into from Nov 11, 2022

Conversation

viveklak
Copy link
Contributor

@viveklak viveklak commented Nov 3, 2022

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Diff for pulumi-azuread with merge commit 80cb9fb

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Diff for pulumi-random with merge commit 80cb9fb

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Diff for pulumi-gcp with merge commit 80cb9fb

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Diff for pulumi-azure with merge commit 80cb9fb

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Diff for pulumi-aws with merge commit 80cb9fb

@viveklak viveklak requested a review from a team November 8, 2022 05:10
@@ -35,22 +35,33 @@ jobs:
id: gomod
run: >-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is fine, but the other way of fixing this is to use the | character instead. | makes more sense for lines of code. > is designed for allowing wrapping for blocks of text - hence you have to use 2 line breaks to get 1 real line break output.

Suggested change
run: >-
run: |

Reference: https://yaml-multiline.info/

git commit -m "Updated modules"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cool workflow, TIL about repo-sync/pull-request@v2.6.2 automation piece! Nice!

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but +1 to what Daniel said.

@viveklak
Copy link
Contributor Author

I will merge this and fix the yaml multiline subsequently. This was blindly copied from what we do in the native providers.

@viveklak viveklak merged commit 8196576 into master Nov 11, 2022
@viveklak viveklak deleted the vl/AutoUpdate branch November 11, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants