Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto update pulumi/pulumi weekly #629

Merged
merged 1 commit into from Oct 28, 2022
Merged

Auto update pulumi/pulumi weekly #629

merged 1 commit into from Oct 28, 2022

Conversation

viveklak
Copy link
Contributor

@viveklak viveklak commented Oct 27, 2022 •
edited

I have no idea how to test this.. I copied this from ci-mgmt and made some changes. Will try it out and see if it works after merge.

@github-actions
Copy link

Diff for pulumi-azuread with merge commit ea031a6

@github-actions
Copy link

Diff for pulumi-random with merge commit ea031a6

@github-actions
Copy link

Diff for pulumi-gcp with merge commit ea031a6

@github-actions
Copy link

Diff for pulumi-azure with merge commit ea031a6

@viveklak viveklak requested review from guineveresaenger and a team October 27, 2022 19:22
@github-actions
Copy link

Diff for pulumi-aws with merge commit ea031a6

@t0yv0
Copy link
Member

t0yv0 commented Oct 28, 2022

There's a way to make workloads trigger-able from GitHub UI. Like this one: https://github.com/pulumi/examples/blob/master/.github/workflows/performance_metrics_cron.yml#L3

It has to be on main branch first. The way I tested before:

  1. merge a PR making an empty triggerable workflow on main branch
  2. stand up a PR with the meat of the changes for the logic
  3. trigger it manually from the branch to test the PR
  4. when happy merge the PR

This assumes the logic is reasonably non-destructive and has safe side-effects for testing.

guineveresaenger
guineveresaenger approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - since we're currently not auto merging PRs I see no obvious risk here.

@viveklak viveklak merged commit fe608ee into master Oct 28, 2022
@viveklak viveklak deleted the vl/AutoUpdate branch October 28, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guineveresaenger guineveresaenger guineveresaenger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viveklak @t0yv0 @guineveresaenger