Support defining extra resources and functions #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the existing `ExtraTypes` field, add `ExtraResources` and `ExtraFunctions` fields to `ProviderInfo` to support defining extra schema for additional resources and functions. These could be for overlays or additional resources and/or functions implemented in a "multiplexed" provider.
justinvp
commented
Oct 20, 2022
Comment on lines
+76
to
+77
| ExtraResources map[string]pschema.ResourceSpec // a map of Pulumi token to schema type for extra resources. | ||
| ExtraFunctions map[string]pschema.FunctionSpec // a map of Pulumi token to schema type for extra functions. |
There was a problem hiding this comment.
ExtraResources and ExtraFunctions are the only additions here.
justinvp
commented
Oct 20, 2022
Comment on lines
+309
to
+322
| for token, res := range g.info.ExtraResources { | ||
| if _, defined := spec.Resources[token]; defined { | ||
| return pschema.PackageSpec{}, fmt.Errorf("failed to define extra resources: %v is already defined", token) | ||
| } | ||
| spec.Resources[token] = res | ||
| } | ||
|
|
||
| for token, fun := range g.info.ExtraFunctions { | ||
| if _, defined := spec.Functions[token]; defined { | ||
| return pschema.PackageSpec{}, fmt.Errorf("failed to define extra functions: %v is already defined", token) | ||
| } | ||
| spec.Functions[token] = fun | ||
| } | ||
|
|
There was a problem hiding this comment.
These loops are equivalent to the loop above on line 302 for ExtraTypes.
|
Diff for pulumi-azuread with merge commit 222736f |
|
Diff for pulumi-random with merge commit 222736f |
|
Diff for pulumi-gcp with merge commit 222736f |
|
Diff for pulumi-azure with merge commit 222736f |
|
Diff for pulumi-aws with merge commit 222736f |
guineveresaenger
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the existing
ExtraTypesfield, addExtraResourcesandExtraFunctionsfields toProviderInfoto support defining extra schema for additional resources and functions. These could be for overlays or additional resources and/or functions implemented in a "multiplexed" provider.