Enable DiffStrategy PlanState by default #1976
Conversation
This has been rolled out to GCP and AWS providers for a considerable time and should be the new default behavior. Retaining the WithDiffStrategy and similar functions as deprecated to avoid breaking provider builds that set them.
|
Tests uncovered a change in behavior, logging it in #1977 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1976 +/- ##
==========================================
+ Coverage 60.55% 60.58% +0.03%
==========================================
Files 331 331
Lines 44726 44625 -101
==========================================
- Hits 27084 27038 -46
+ Misses 16120 16070 -50
+ Partials 1522 1517 -5 ☔ View full report in Codecov by Sentry. |
|
Should we run this through downstream tests? Do we expect this to break anything? |
| @@ -21,6 +21,8 @@ import ( | |||
|
|
|||
| // Configures how the provider performs Diff. Since this is a sensitive method that can result in unexpected breaking | |||
| // changes, using a configurable DiffStrategy as a feature flag assists gradual rollout. | |||
| // | |||
| // Deprecated. | |||
There was a problem hiding this comment.
Let's make sure there is an issue to clean these up.
|
I can fire up downstream tests, good idea. |
|
python scripts/downstream_checks.py --hash 5b75c91 ~/code/pulumi-terraform-bridge |
|
aiven and cloudamqp are unrelated. Fastly is the same panic as in #1964 Just restarted f5bigip, the rest were flakes |
|
|
Excellent this is down to #1964 having a look. |
This has been rolled out to GCP and AWS providers for a considerable time and should be the new default behavior. Retaining the WithDiffStrategy and similar functions as deprecated to avoid breaking provider builds that set them.