Dynamic Bridged Providers #1973
Draft
+6,943
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1973 +/- ##
==========================================
- Coverage 61.36% 60.72% -0.64%
==========================================
Files 334 352 +18
Lines 44951 45494 +543
==========================================
+ Hits 27583 27628 +45
- Misses 15841 16342 +501
+ Partials 1527 1524 -3 ☔ View full report in Codecov by Sentry. |
iwahbe
force-pushed
the
iwahbe/dynamic-bridged-providers
branch
from
99e477c
to
e54ade4
Compare
iwahbe
force-pushed
the
iwahbe/dynamic-bridged-providers
branch
6 times, most recently
from
09a8275
to
f7964f1
Compare
Dropping to a lower level avoid cache corruption (which `EnsureProviderVersions` inexplicably allows) and allows us to avoid littering the working directory with local cache info.
This is simply more consistent.
Follow-up on dfda673.
iwahbe
force-pushed
the
iwahbe/dynamic-bridged-providers
branch
from
7a7f115
to
70f5070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR for dynamically bridged providers.
Currently, support is limited to Parameterize and GetSchema calls. We are getting very close to where it would be helpful for multiple people to work on the project, so I'd like to get ready to merge soon.