Allow delegating IDs to nested properties #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
added a commit
to pulumi/pulumi-meraki
that referenced
this pull request
May 13, 2024
This reduces the manual work for incoming resources as much as possible.
It also fixes two
resources ("meraki_administered_licensing_subscription_subscriptions_claim", "meraki_administered_licensing_subscription_subscriptions_claim_key_validate") that would
not have worked in practice (since their ID did not exist).
This PR introduces a dependency on
pulumi/pulumi-terraform-bridge#1968.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1968 +/- ##
==========================================
- Coverage 60.56% 60.55% -0.01%
==========================================
Files 331 331
Lines 44726 44728 +2
==========================================
- Hits 27090 27087 -3
- Misses 16113 16118 +5
Partials 1523 1523 ☔ View full report in Codecov by Sentry. |
iwahbe
added a commit
to pulumi/pulumi-meraki
that referenced
this pull request
May 13, 2024
This reduces the manual work for incoming resources as much as possible.
It also fixes two
resources ("meraki_administered_licensing_subscription_subscriptions_claim", "meraki_administered_licensing_subscription_subscriptions_claim_key_validate") that would
not have worked in practice (since their ID did not exist).
This PR introduces a dependency on
pulumi/pulumi-terraform-bridge#1968.
mjeffryes
approved these changes
May 13, 2024
iwahbe
added a commit
to pulumi/pulumi-meraki
that referenced
this pull request
May 13, 2024
This reduces the manual work for incoming resources as much as possible.
It also fixes two
resources ("meraki_administered_licensing_subscription_subscriptions_claim", "meraki_administered_licensing_subscription_subscriptions_claim_key_validate") that would
not have worked in practice (since their ID did not exist).
This PR introduces a dependency on
pulumi/pulumi-terraform-bridge#1968.
iwahbe
added a commit
to pulumi/pulumi-meraki
that referenced
this pull request
May 13, 2024
* Normalize ID Application
This reduces the manual work for incoming resources as much as possible.
It also fixes two
resources ("meraki_administered_licensing_subscription_subscriptions_claim", "meraki_administered_licensing_subscription_subscriptions_claim_key_validate") that would
not have worked in practice (since their ID did not exist).
This PR introduces a dependency on
pulumi/pulumi-terraform-bridge#1968.
* Simplify the ID field selection algorithm
Thanks @mjeffryes for the
suggestion. (#5 (comment))
iwahbe
added a commit
to pulumi/pulumi-meraki
that referenced
this pull request
May 13, 2024
* Normalize ID Application
This reduces the manual work for incoming resources as much as possible.
It also fixes two
resources ("meraki_administered_licensing_subscription_subscriptions_claim", "meraki_administered_licensing_subscription_subscriptions_claim_key_validate") that would
not have worked in practice (since their ID did not exist).
This PR introduces a dependency on
pulumi/pulumi-terraform-bridge#1968.
* Simplify the ID field selection algorithm
Thanks @mjeffryes for the
suggestion. (#5 (comment))
iwahbe
added a commit
to pulumi/pulumi-meraki
that referenced
this pull request
May 13, 2024
* Normalize ID Application
This reduces the manual work for incoming resources as much as possible.
It also fixes two
resources ("meraki_administered_licensing_subscription_subscriptions_claim", "meraki_administered_licensing_subscription_subscriptions_claim_key_validate") that would
not have worked in practice (since their ID did not exist).
This PR introduces a dependency on
pulumi/pulumi-terraform-bridge#1968.
* Simplify the ID field selection algorithm
Thanks @mjeffryes for the
suggestion. (#5 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes a more general form of
DelegateIDField:DelegateIDProperty.DelegateIDPropertyallows delegating to any property in state, not just top level properties.Needed by pulumi/pulumi-meraki#5.