-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix weekly Pulumi update job #1003
Conversation
go mod download | ||
|
||
go mod tidy | ||
make tidy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of tidy-ing the top-level Go module, it will tidy every Go module in the repo.
|
||
go get github.com/pulumi/pulumi/sdk/v3 | ||
echo "Update Pulumi dependencies to $PULUMI_VERSION" | ||
go run scripts/build.go update-pulumi-deps "$PULUMI_VERSION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of updating dependencies in the top-level Go module, this will update every Go module in the repo.
@@ -42,13 +44,12 @@ jobs: | |||
|
|||
git checkout -b update-pulumi/${{ github.run_id }}-${{ github.run_number }} | |||
|
|||
go get github.com/pulumi/pulumi/pkg/v3 | |||
PULUMI_VERSION=$(pulumi version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of an approximation here.. Assuming we are going to compute the latest version of SDK and PKG by computing the latest version of Pulumi CLI. Seems cleanest for now as they do in practice update in sync. Can be refined though to find the latest version of Pulumi Go SDK specifically.
@@ -33,6 +33,7 @@ func usage() { | |||
|
|||
func updatePulumiDeps() { | |||
ver := os.Args[2] | |||
ver = strings.TrimPrefix(ver, "v") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job didn't like versions passed with a v1.2.3 but prefers 1.2.3.
Diff for pulumi-azuread with merge commit 71e4dc5 |
Diff for pulumi-azuread with merge commit 8e753c1 |
Diff for pulumi-random with merge commit 8e753c1 |
Diff for pulumi-gcp with merge commit 71e4dc5 |
Diff for pulumi-azure with merge commit 71e4dc5 |
Diff for pulumi-gcp with merge commit 8e753c1 |
Diff for pulumi-azure with merge commit 8e753c1 |
Fixes #910
Since the workflow was written we've added multiple Go modules to the repository. The workflow assumed a single top-level Go module.