Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed version in SDKs #410

Merged
merged 3 commits into from
May 9, 2024
Merged

Embed version in SDKs #410

merged 3 commits into from
May 9, 2024

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented May 8, 2024 •
edited

Part of pulumi/ci-mgmt#915

  1. Enable embedding version number in each language.
  2. Configure CI to allow changes to files which include the version number and use new push-based Go SDK publishing.
  3. Remove explicit dependencies (defer to the languages's defaults).

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Is README.md missing any configuration options?

caCertFile not found in Configuration section
clientCertFile not found in Configuration section
clientKeyFile not found in Configuration section
clientKeyPassphrase not found in Configuration section
kafkaVersion not found in Configuration section
saslAwsCredsDebug not found in Configuration section
saslAwsProfile not found in Configuration section
saslAwsRegion not found in Configuration section
saslAwsRoleArn not found in Configuration section
saslTokenUrl not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

@danielrbradley danielrbradley mentioned this pull request May 8, 2024
Open
78 tasks
@danielrbradley
Embed version in SDKs
f464965 
1. Enable embedding version number in each language.
2. Configure CI to allow changes to files which include the version number and use new push-based Go SDK publishing.
3. Remove explicit dependencies (defer to the languages's defaults).
@danielrbradley danielrbradley requested review from VenelinMartinov and a team May 8, 2024 14:49
@danielrbradley danielrbradley self-assigned this May 8, 2024
flostadler
flostadler reviewed May 8, 2024
View reviewed changes
sdk/python/pyproject.toml Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Kafka.csproj Outdated Show resolved Hide resolved
VenelinMartinov
VenelinMartinov approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the discussion on versions, based on that seems fine until we release pulumi v4, so probably safe for now

@danielrbradley
Revert python and dotnet requirements
c416a7b 
- We want to depend on the curret major version for python. This is being fixed in codegen here: pulumi/pulumi#16151
- The default dotnet range resolves to minimum version rather than the latest version which could be problematic.
@danielrbradley
Add comment on allowed files
cfa99c5
@danielrbradley danielrbradley merged commit 3dad44a into master May 9, 2024
17 checks passed
@danielrbradley danielrbradley deleted the embed-sdk-version branch May 9, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flostadler flostadler flostadler approved these changes

@VenelinMartinov VenelinMartinov VenelinMartinov approved these changes

Assignees

@danielrbradley danielrbradley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielrbradley @flostadler @VenelinMartinov