Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Add new transforms docs #4044

Closed
wants to merge 1 commit into from
Closed

Add new transforms docs #4044

wants to merge 1 commit into from

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Mar 12, 2024

Description

Checklist:

  • I have reviewed the style guide.
  • If blogging, I have reviewed the blogging guide.
  • I have manually confirmed that all new links work.
  • I added aliases (i.e., redirects) for all filename changes.
  • If making css changes, I rebuilt the bundle.

@Frassle Frassle force-pushed the fraser/transforms branch 4 times, most recently from 57d130c to 3868da2 Compare March 15, 2024 08:56
@Frassle Frassle force-pushed the fraser/transforms branch 3 times, most recently from 2190533 to 8d9d6a8 Compare March 20, 2024 16:39
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 8d9d6a8 is ready! 🎉

http://pulumi-hugo-origin-pr-4044-8d9d6a8f.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 4afab44 is ready! 🎉

http://pulumi-hugo-origin-pr-4044-4afab444.s3-website.us-west-2.amazonaws.com.

@justinvp justinvp mentioned this pull request Apr 1, 2024
Open
21 tasks
@Frassle Frassle marked this pull request as ready for review May 8, 2024 08:02
lukehoban
lukehoban reviewed May 8, 2024
View reviewed changes
...registry/CurrentUser/software/microsoft/csdevkit/v1/pids/12603_133547972322250879/values.xml Outdated Show resolved Hide resolved
themes/default/content/docs/concepts/options/_index.md Outdated Show resolved Hide resolved
themes/default/content/docs/concepts/options/parent.md Show resolved Hide resolved
themes/default/content/docs/concepts/options/transforms.md Outdated Show resolved Hide resolved
themes/default/content/docs/concepts/options/transforms.md Outdated

Each transform is a callback that gets invoked by the Pulumi engine. It receives the resource type, name, input properties, and resource options. The callback returns a new set of resource input properties and resource options that will be used to construct the resource instead of the original values.

## Transforms vs Transformations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we split this into two parts:

  1. A list of differences in capabilities
  2. A migration guide

For the migration guide, I’d love to somehow move it out of the mainline of this page - but not sure how. I almost wonder if we should put it in the transformations page as part of mentioning that that is deprecated, and then cross link it from here?

themes/default/content/docs/concepts/options/transforms.md Outdated
}
return null;
}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’ll need these code snippets in all languages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one only really makes sense for C#. The other languages don't have GetResourceType like this.

themes/default/content/docs/concepts/options/parent.md Show resolved Hide resolved
@Frassle Frassle force-pushed the fraser/transforms branch 2 times, most recently from b651d1c to b5bc8ff Compare May 9, 2024 14:23
@pulumi-bot
Copy link
Collaborator

Your site preview for commit b5bc8ff is ready! 🎉

http://pulumi-hugo-origin-pr-4044-b5bc8ff1.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit f2b412d is ready! 🎉

http://pulumi-hugo-origin-pr-4044-f2b412d5.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 94da6bf is ready! 🎉

http://pulumi-hugo-origin-pr-4044-94da6bf0.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit a20a142 is ready! 🎉

http://pulumi-hugo-origin-pr-4044-a20a142d.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 3e433d8 is ready! 🎉

http://pulumi-hugo-origin-pr-4044-3e433d8c.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 43739fc is ready! 🎉

http://pulumi-hugo-origin-pr-4044-43739fce.s3-website.us-west-2.amazonaws.com.

@justinvp justinvp self-requested a review May 14, 2024 07:11
@justinvp justinvp mentioned this pull request May 17, 2024
Draft
@sean1588 sean1588 closed this May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgummerer tgummerer tgummerer left review comments

@lukehoban lukehoban lukehoban left review comments

@ericrudder ericrudder ericrudder left review comments

@interurban interurban Awaiting requested review from interurban interurban is a code owner

@cnunciato cnunciato Awaiting requested review from cnunciato cnunciato is a code owner

@justinvp justinvp Awaiting requested review from justinvp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Frassle @pulumi-bot @tgummerer @lukehoban @ericrudder @sean1588