Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial sketch of using azcore client #3128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikhailshilkov
Copy link
Member

I haven't wired it anywhere, so it's no functional change, but I was playing with azcore to see if it solves #903 (it does not) and implemented the minimal version of CRUD. It worked for resource groups/vnets/subnets, but obviously lots of work to do to make it universal and then gradually introduce it to users.

First step towards #1464

@thomas11 @danielrbradley @mjeffryes Do you folks think it's worth pursuing?

Copy link

github-actions bot commented Mar 6, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@thomas11
Copy link
Contributor

thomas11 commented Mar 6, 2024

Nice! I think it's definitely worth pursuing since we have to do #1464 at some point. The question is, as always, prioritization, i.e., when to do it.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 108 lines in your changes are missing coverage. Please review.

Project coverage is 60.26%. Comparing base (1586bd5) to head (fc82f2c).
Report is 1 commits behind head on master.

Files Patch % Lines
provider/pkg/azure/client_azcore.go 0.00% 108 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3128      +/-   ##
==========================================
- Coverage   60.83%   60.26%   -0.58%     
==========================================
  Files          71       72       +1     
  Lines       11353    11461     +108     
==========================================
  Hits         6907     6907              
- Misses       3883     3991     +108     
  Partials      563      563              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants