Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard devcontainer #1269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danielrbradley
Copy link
Member

Copied from pulumi/pulumi - makes it easier to use project in Codespaces and GitPod.

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.
Looking good! No API changes found.

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.
Looking good! No API changes found.

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.
Looking good! No API changes found.

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.
Looking good! No API changes found.

@Frassle
Copy link
Member

Frassle commented Nov 4, 2021

Wonder if there's an easy way to keep these in sync, as I've pretty much just made a change to the pulumi/pulumi one to fix a build on the latest base image (pulumi/pulumi@f8a98b2)

@danielrbradley danielrbradley added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 5, 2021
@danielrbradley
Copy link
Member Author

Not sure on the alternative approaches without knowing how much different projects can vary in their required setup. I guess the ideal would be to have a single image pre-built for each of Codespaces and another for Gitpod as they don't seem to be compatible, then each project points to the latest image. Would it be worth getting this in as-is if it's functional, with an aim to start a wider conversation around standard virtualized development environments?

@sanmai-NL
Copy link

sanmai-NL commented Dec 21, 2022

Wonder if there's an easy way to keep these in sync, as I've pretty much just made a change to the pulumi/pulumi one to fix a build on the latest base image (pulumi/pulumi@f8a98b2)

You can use Git submodules and reuse dev container configurations across repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants