Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider refactoring from go-autorest to azcore #1464

Open
mikhailshilkov opened this issue Feb 1, 2022 · 0 comments
Open

Consider refactoring from go-autorest to azcore #1464

mikhailshilkov opened this issue Feb 1, 2022 · 0 comments
Labels
kind/engineering Work that is not visible to an external user

Comments

@mikhailshilkov
Copy link
Member

From this comment:

we will be deprecating go-autorest in the coming year (exact date is still being worked out). It will be replaced by azcore. If you're interested in the LRO-specific bits you can find them here.

Consider switching to azcore for the provider.
@mikhailshilkov mikhailshilkov added the kind/engineering Work that is not visible to an external user label Feb 1, 2022
@thomas11 thomas11 mentioned this issue Feb 2, 2024
Merged
thomas11 added a commit that referenced this issue Feb 8, 2024
@thomas11
Extract low-level Autorest Azure client from provider (#3062)
d71ffb8 
A refactoring that's not supposed to change any behavior. The goals were to
- separate the lower level of Azure request handling from the core
provider logic
  - make the huge provider.go file a bit more pliable
- prepare for the migration off of go-autorest which we need to tackle
at some point: #1464

As a boundary between the `provider` module and the new `azure` module I
used the following guideline, which is implemented in this PR:
- `provider` does not depend on github.com/Azure/go-autorest/autorest
(encapsulated by `azure`)
- `azure` does not depend on
github.com/pulumi/pulumi-azure-native/v2/provider/pkg/resources
(resources are decomposed into primitive HTTP request arguments in
`provider`)

As a wart, `provider` still depends on
github.com/Azure/go-autorest/autorest/azure for handling of Azure
environments (global, China, etc.), but that's a lesser concern.

I'm aware the new `azure` module has zero tests so far, but its code
didn't have any before and most of it is very side-effect heavy.
@mikhailshilkov mikhailshilkov mentioned this issue Mar 6, 2024
Open
@thomas11 thomas11 mentioned this issue Mar 25, 2024
Open
@mikhailshilkov mikhailshilkov mentioned this issue May 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikhailshilkov