Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yarn as a "quick-and-easy" way to hack the editor #6

Merged
merged 8 commits into from
Jul 27, 2022

Conversation

mauricioszabo
Copy link
Contributor

@mauricioszabo mauricioszabo commented Jul 23, 2022

This PR adds support for running:

yarn install
yarn build
yarn start

As a way to quickly open up the text editor, instead of going though the trouble of running the bootstrap script. It also runs on Node 16, and it's completely non-invasive.

So, opinions on it?

@confused-Techie
Copy link
Member

I really feel the easier we can make running and testing the editor, the better for newcomers, and the easier it is for you to get help within core. I'm all for it

@meadowsys
Copy link
Member

I think it looks good! though can't see how the playwright related dev dependencies are used?

@mauricioszabo
Copy link
Contributor Author

@autumnblazey you're right, there are things that came from my base branched that should not be here. I'll update the PR, and also add some documentation on it

@meadowsys
Copy link
Member

alrigty! and no problem

@kaosine
Copy link
Member

kaosine commented Jul 23, 2022

Wait if it runs on node 16 maybe we should be targeting that? That's the newest lts and gets us up to date (for now). That would allow for further optimizations to be pushed that we probably couldn't get in the older releases possibly. Not to mention the fact going forward we would be able to replace or drop extraneous packages either internally or from npm. Since I know a lot of ones from npm are likely to break sooner or later with how out of date some are.

@confused-Techie
Copy link
Member

Just saw the changes you've made to fixing the devDependencies, looks rad

package.json Outdated Show resolved Hide resolved
@kaosine
Copy link
Member

kaosine commented Jul 26, 2022

This works on fedora, had to install a bit of extra stuff but it works(probably the same for other rpm based distros since I assume they've all got the same package names. Commands for this are:

Needs toolbox to have a standardized build environment:

sudo dnf install toolbox
toolbox create -c <your_name_here> # I also used "-r 36" at the end but this needs to just be whtaever the latest is for the rpm based os being run
toolbox enter <your_name_here>

Then once inside the toolbox:

sudo dnf --assumeyes install make gcc gcc-c++ glibc-devel git-core libsecret-devel rpmdevtools libX11-devel libxkbfile-devel nss atk gdk-pixbuf2 gtk3 mesa-dri-drivers

nvm install 16```

Then use the yarn commands to build and run it. Probably should add to the readme tbh or a build.md. That was a weird set of debugging I had to do

@mauricioszabo mauricioszabo merged commit 1c36bf8 into master Jul 27, 2022
@mauricioszabo mauricioszabo deleted the use-yarn branch July 27, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants